Fix column lengths on migrations table to fix index #28086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
approved these changes
Jun 12, 2017
|
@tomneedham please backport to stable10. I guess the auto-truncation logic (or whatever was discussed) for the account table and search params will be done in a separate PR ? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces the lengths of the app and version columns in the migrations table so that the index that is created is not too long when using 4 byte database encodings and you have strict mode enabled.
Altered the create table method to use the new lengths (for new installs) and added a migration step to alter the existing table if it is already created (on upgrades)
Related Issue
Install is blocked when using 4 byte support with strict mode enabled.
#28030
Motivation and Context
Broken installs.
How Has This Been Tested?
New installs. Upgrades. Strict mode. mb4 encoding with MySQL.
Types of changes
Checklist: